Address issue #390, Adjustment types for inventory need to be localized #1041
Conversation
There was a problem hiding this comment.
@sweeneydavidj Thanks for the PR. Looks good to me except for the organization of the localization values. Those values should be under inventory.labels, not in their own section under inventory.
Also, app/locales/en/translations.js was recently reorganized to be sorted alphabetically, so you will notice a merge conflict with your version of that file. Its probably easiest to just grab the latest version from master and add your labels to that vs trying to merge your file with master.
app/locales/en/translations.js
Outdated
| @@ -553,6 +553,13 @@ export default { | |||
| } | |||
| }, | |||
| inventory: { | |||
| adjustmentTypes: { | |||
There was a problem hiding this comment.
These values should be under inventory.labels, eg:
inventory: {
...
labels: {
...
addAdjustmentType 'Add',
removeAdjustmentType: 'Remove',
...
}
}
|
@jkleinsc Thanks for the review. I've reorganized the localization values as suggested. |
|
@sweeneydavidj looks good to me. Thanks for the PR! |
Fixes #390.
There are two issues, which are related:
Localization of drop-down
Added translation keys to app/mixins/inventory-adjustment-types.js. So now the drop-down list for Adjustment Types is translated. Added English translations. I didn't update the files for the other languages - I'm not sure of the process for getting translation text in multiple languages - let me know if you'd like me to do something more about that.
Localization of the 'submit' button.
In app/inventory/adjust/controller.js I use the the Transaction Type to find a localized Adjustment Type name.
cc @HospitalRun/core-maintainers