feat(patient): add input validation #2032
Conversation
|
|
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/hk3hui3qb |
jackcmeyer
added
patients
|
@lucasbn can you resolve the 3 conflicts? thanks! |
|
This pull request introduces 1 alert when merging ee3769e into 91a1a5c - view on LGTM.com new alerts:
|
| dateOfBirth: addDays(new Date(), 4).toISOString(), | ||
| suffix: '061002', | ||
| prefix: '061002', | ||
| familyName: '061002', | ||
| preferredLanguage: '061002', |
There was a problem hiding this comment.
This test was changed to only check for required fields. I think that we should remove everything but givenName in this test.
I think we'll need to add some other test which checks for numbers in the string.
There was a problem hiding this comment.
I believe this is why the build is failing.
| @@ -386,6 +395,10 @@ describe('patients slice', () => { | |||
| id: expectedPatientId, | |||
| givenName: undefined, | |||
| dateOfBirth: addDays(new Date(), 4).toISOString(), | |||
| suffix: '061002', | |||
There was a problem hiding this comment.
let's change this test to only test the numbers in the values.
matteovivona
added
the
in progress
Fixes #1976
Changes proposed in this pull request: