Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

refactor: use Table component #2189

Merged
merged 15 commits into from
Jun 30, 2020
Merged

refactor: use Table component #2189

merged 15 commits into from
Jun 30, 2020

Conversation

jackcmeyer
Copy link
Member

@jackcmeyer jackcmeyer commented Jun 29, 2020 •
edited
Loading

Changes proposed in this pull request:

  • refactor tables to use Table component
  • fixed an issue with labs table not displaying results
  • fixed an issue with incidents table not displaying results

@jackcmeyer jackcmeyer added this to the v2.0 milestone Jun 29, 2020
@jackcmeyer jackcmeyer requested review from fox1t, matteovivona and a user June 29, 2020 04:13
@vercel
Copy link

vercel bot commented Jun 29, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/nopmq81g6
✅ Preview: https://hospitalrun-frontend-git-table-refactor.hospitalrun.vercel.app

@gitpod-io
Copy link

gitpod-io bot commented Jun 29, 2020 •
edited
Loading

@jackcmeyer jackcmeyer added labs issue/pull request that interacts with labs module 🐛bug issue/pull request that documents/fixes a bug 🚀enhancement an issue/pull request that adds a feature to the application labels Jun 29, 2020
fox1t
fox1t previously approved these changes Jun 29, 2020
View reviewed changes
ghost
ghost reviewed Jun 29, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A little note on default classes.

src/patients/list/ViewPatients.tsx Outdated Show resolved Hide resolved
@matteovivona matteovivona removed their request for review June 29, 2020 19:55
@matteovivona matteovivona merged commit ae589d0 into master Jun 30, 2020
@matteovivona matteovivona deleted the table-refactor branch June 30, 2020 05:56
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@fox1t fox1t fox1t left review comments

Assignees
No one assigned
Labels
🐛bug issue/pull request that documents/fixes a bug 🚀enhancement an issue/pull request that adds a feature to the application labs issue/pull request that interacts with labs module
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jackcmeyer @fox1t @matteovivona