Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(incidents): create downloadable incidents csv report #2311

Merged
merged 18 commits into from
Sep 7, 2020
Merged

feat(incidents): create downloadable incidents csv report #2311

merged 18 commits into from
Sep 7, 2020

Conversation

reidmeyer
Copy link
Contributor

@reidmeyer reidmeyer commented Aug 16, 2020 •
edited by blestab
Loading

  • Added a button for the download reported incidents to CSV
  • Currently active incidents filter also applies to the downloaded CSV records

image

re #2292

Newly added dependencies with Bundlephobia links:

https://bundlephobia.com/result?p=json2csv@5.0.1

@gitpod-io
Copy link

gitpod-io bot commented Aug 16, 2020 •
edited
Loading

@reidmeyer reidmeyer marked this pull request as ready for review August 16, 2020 06:19
@blestab blestab changed the title feat(download csv of incident table): uses json2csv. filters data feat(incidents): create downloadable incidents csv report Aug 17, 2020
@blestab blestab added the 🚀enhancement an issue/pull request that adds a feature to the application label Aug 17, 2020
@blestab blestab added this to the v2.0 milestone Aug 17, 2020
@blestab blestab linked an issue Aug 17, 2020 that may be closed by this pull request
Create downloadable incidents csv report #2292
Closed
@vercel
Copy link

vercel bot commented Aug 17, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/k9l9zgjrk
✅ Preview: https://hospitalrun-frontend-git-fork-reidmeyer-incidentscsv.hospitalrun.vercel.app

blestab
blestab previously approved these changes Aug 17, 2020
View reviewed changes
jackcmeyer
jackcmeyer suggested changes Aug 18, 2020
View reviewed changes
src/incidents/list/ViewIncidentsTable.tsx Outdated Show resolved Hide resolved
src/incidents/list/ViewIncidentsTable.tsx Outdated Show resolved Hide resolved
src/incidents/list/ViewIncidentsTable.tsx Outdated Show resolved Hide resolved
src/incidents/list/ViewIncidentsTable.tsx Outdated Show resolved Hide resolved
src/incidents/list/ViewIncidentsTable.tsx Outdated Show resolved Hide resolved
src/incidents/list/ViewIncidentsTable.tsx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview August 19, 2020 16:47 Inactive
@matteovivona matteovivona removed their request for review August 19, 2020 17:37
@reidmeyer reidmeyer requested a review from jackcmeyer August 25, 2020 23:23
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Aug 30, 2020
@reidmeyer
Copy link
Contributor Author

@jackcmeyer @tehkapa @fox1t , I've made the requested changes and am awaiting further review to have this merged.

fox1t
fox1t suggested changes Sep 2, 2020
View reviewed changes
Copy link
Member

@fox1t fox1t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add tests too.

@reidmeyer
Copy link
Contributor Author

On it.

@reidmeyer reidmeyer requested a review from fox1t September 6, 2020 05:56
@reidmeyer
Copy link
Contributor Author

Ready to be re-reviewed @fox1t .

@fox1t
Copy link
Member

fox1t commented Sep 7, 2020

LGTM

@fox1t fox1t merged commit 08d7965 into HospitalRun:master Sep 7, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@fox1t fox1t fox1t approved these changes

@blestab blestab blestab left review comments

@jackcmeyer jackcmeyer Awaiting requested review from jackcmeyer

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application in progress indicates that issue/pull request is currently being worked on incidents
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Create downloadable incidents csv report
5 participants
@reidmeyer @fox1t @blestab @jackcmeyer @matteovivona