Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(patient): add panel to display useful patient information #2333

Merged
merged 12 commits into from
Oct 9, 2020
Merged

feat(patient): add panel to display useful patient information #2333

merged 12 commits into from
Oct 9, 2020

Conversation

AlexTan331
Copy link
Contributor

fix #2259

Changes proposed in this pull request:

  • add panel to display useful patient information

@vercel
Copy link

vercel bot commented Aug 26, 2020 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/3nf5r3wpo
✅ Preview: https://hospitalrun-frontend-git-important-patient-info.hospitalrun.vercel.app

@gitpod-io
Copy link

gitpod-io bot commented Aug 26, 2020 •
edited
Loading

@michaelkramer
Copy link
Contributor

@AlexTan331 I have downloaded and ran your branch. Would you be open for some critiques?
I can send a more detailed list if you are interested.

  1. Mobile view is bad
  2. The add allergies button is miss placed.
    image
  3. on file src/patients/view/ViewPatient.tsx there is lots of repeat code. Making an Array and then map through would allow for quicker edits in the future.

I have more, but only if you're interested.

@AlexTan331
Copy link
Contributor Author

@michaelkramer Thank you for your critiques.
This is the my first attempt that successfully made the overall layout in place. It is obviously not ideal, and the reason why I didn't mark it as draft is because I am open to anyone just like you to provide useful suggestion/critiques so that I know if I am on the right path.
So please share your opinions.

@jackcmeyer jackcmeyer added patients issue/pull request that interacts with patients module 🚀enhancement an issue/pull request that adds a feature to the application labels Aug 27, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Aug 27, 2020
blestab
blestab suggested changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@blestab blestab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a few lines of code commented out. Perhaps we should remove those if there is no plan to use them anymore.

src/patients/view/ImportantPatientInfo.tsx Outdated Show resolved Hide resolved
@AlexTan331 AlexTan331 marked this pull request as draft August 27, 2020 21:42
@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Aug 30, 2020
@matteovivona matteovivona marked this pull request as ready for review September 20, 2020 09:57
@matteovivona
Copy link
Contributor

@AlexTan331 there are conflicts to resolve

@AlexTan331 AlexTan331 marked this pull request as draft September 23, 2020 16:05
@vercel vercel bot temporarily deployed to Preview September 28, 2020 08:17 Inactive
@matteovivona matteovivona marked this pull request as ready for review September 28, 2020 08:18
@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2020

This pull request introduces 1 alert when merging 4a65e4b into c1b850e - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2020

This pull request introduces 1 alert when merging 67aab7c into e41b000 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

matteovivona
matteovivona suggested changes Sep 28, 2020
View reviewed changes
src/patients/view/ViewPatient.tsx Outdated Show resolved Hide resolved
@lgtm-com
Copy link

lgtm-com bot commented Sep 28, 2020

This pull request introduces 1 alert when merging 315c544 into e41b000 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@morrme
Copy link
Contributor

morrme commented Oct 8, 2020

LGTM

@matteovivona matteovivona merged commit ab52a94 into HospitalRun:master Oct 9, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@matteovivona matteovivona matteovivona approved these changes

@jackcmeyer jackcmeyer Awaiting requested review from jackcmeyer

@fox1t fox1t Awaiting requested review from fox1t

@blestab blestab Awaiting requested review from blestab

Assignees
No one assigned
Labels
🚀enhancement an issue/pull request that adds a feature to the application hacktoberfest-accepted in progress indicates that issue/pull request is currently being worked on patients issue/pull request that interacts with patients module
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.

Update patient profile page to always display useful information
6 participants
@AlexTan331 @michaelkramer @matteovivona @morrme @blestab @jackcmeyer