Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Code for updating invoice headers and footers #419

Closed
wants to merge 8 commits into from
Closed

Conversation

reybango
Copy link

Fixes # .

Changes proposed in this pull request:

Adding functionality to administration section to allow users to update invoice headers and footers.

cc @HospitalRun/core-maintainers

@reybango
Copy link
Author

@taras here's the PR for the invoice header work.


model: function() {
return new Ember.RSVP.Promise(function(resolve) {
this.get('store').find('option', 'invoice_template').then(function(invoiceOptions) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use the es6 => for keeping the correct this scope

@taras
Copy link
Contributor

taras commented May 9, 2016

@billybonks this PR needs some UI/UX attention. We should pull @jglovier in to look at this and then we can start doing clean up. Adding i18n and such.

@jkleinsc jkleinsc mentioned this pull request Jul 7, 2016
@jglovier
Copy link
Member

jglovier commented Jul 7, 2016

Can someone please post some screenshots of the UI changes in this PR?

@taras
Copy link
Contributor

taras commented Jul 17, 2016

This PR is for issue #370

@taras
Copy link
Contributor

taras commented Jul 17, 2016

Screenshots

Here is what the new screens look like at the moment. We need to make them clearer.

Administration -> Invoice Template -> Edit

screen shot 2016-07-17 at 1 06 40 pm

Administration -> Invoice Template -> Preview

screen shot 2016-07-17 at 1 07 47 pm

TODO

  • i18n the template strings
  • [UX/UI] Need design for Administration -> Invoice Templates
  • [UX/UI] Design/content for default templates
  • Pre-populate the database with default template
  • Update Acceptance Tests
  • What do we do with template compiler? (It's currently being pulled from URl. We might want to include it in builds"

/cc @jglovier

@jkleinsc
Copy link
Member

@taras thanks for picking this back up and updating this PR! Looking forward to having Chris and Lennex contributing!

@tangollama tangollama closed this Apr 19, 2017
@tangollama
Copy link
Member

Closing b/c this is covered by other features.

@stukalin stukalin deleted the invoice branch August 29, 2018 07:52
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants