This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
Translate components #560
Merged
Translate components #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billybonks
force-pushed
the
translate/components
branch
2 times, most recently
from
1d5617e to
96e848a
Compare
| @@ -2,7 +2,7 @@ | |||
| <div class="row"> | |||
| <div class="col-xs-5"> | |||
| <div class="form-group required {{quantityClass}}"> | |||
| <label class="control-label">What does 1 {{unitName}} contain?</label> | |||
| <label class="control-label">{{t 'quantity-conv.conversion' name=unitName}}</label> | |||
billybonks
force-pushed
the
translate/components
branch
from
96e848a to
f3208bb
Compare
|
@jkleinsc updated |
| @@ -2,7 +2,7 @@ | |||
| <div class="row"> | |||
| <div class="col-xs-5"> | |||
| <div class="form-group required {{quantityClass}}"> | |||
| <label class="control-label">What does 1 {{unitName}} contain?</label> | |||
| <label class="control-label">{{t 'quantityConv.conversion' name=unitName}}</label> | |||
There was a problem hiding this comment.
Still missing the components prefix. (eg components.quantityConv.conversion).
billybonks
force-pushed
the
translate/components
branch
from
f3208bb to
1005d57
Compare
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translates components files. i refactored take-photo translations to match new style
convention discussed here
#557