Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

address #543 #752

Closed
wants to merge 1 commit into from
Closed

address #543 #752

wants to merge 1 commit into from

Conversation

yasirunilan
Copy link

@yasirunilan yasirunilan commented Oct 18, 2016

Fixes #543 .

Changes proposed in this pull request:
the proposed translation were made in the English translation file.Need a feedback before moving into other languages.
cc @HospitalRun/core-maintainers

@yasirunilan yasirunilan changed the title translation done in english file address #543 Oct 18, 2016
@yasirunilan
Copy link
Author

I have created some changes. Please review and give a feedback

Copy link
Member

@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yasirunilan this isn't exactly what issue #543 is asking to do. Your change simply changes the verbiage to be the same, but @billybonks is suggesting we instead only have 3 messages in total in the translations file for deletions:

en: {
  messages: {
    delete: 'Are you sure you wish to delete {{name}}?'
    delete_singular: 'Are you sure you wish to delete this{{name}}?'
    delete_plural: 'Are you sure you wish to delete {{name}}?'
  }
}

This means that the code that currently uses the old translations needs to be modified to use the new translation keys.

@tangollama
Copy link
Member

@yasirunilan thx again for the PR. Are you intending to implement the changes @jkleinsc or should I close this?

@jkleinsc
Copy link
Member

#992 resolved #543 so I am closing this.

@jkleinsc jkleinsc closed this Apr 24, 2017
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants