Skip to content
This repository was archived by the owner on Aug 17, 2020. It is now read-only.

remove $HOME hack and set multirust folder the 'correct' way #17

Merged
merged 1 commit into from
Jan 11, 2016
Merged

remove $HOME hack and set multirust folder the 'correct' way #17

merged 1 commit into from
Jan 11, 2016

Conversation

hugo
Copy link
Contributor

@hugo hugo commented Jan 6, 2016

Multirust does, in fact, have a way to set its home dir, as specified here

@Hoverbear
Copy link
Owner

Awesome! Thanks for this!

@hugo
Copy link
Contributor Author

hugo commented Jan 6, 2016

Only problem is I can't tell why changing this causes the tests to fail 😐

@Hoverbear
Copy link
Owner

I'll deal with that. :)

@Hoverbear
Copy link
Owner

It's because rand is broken on nightly. :(

Depends on: rust-lang/rust#30713

@hugo
Copy link
Contributor Author

hugo commented Jan 6, 2016

Ah, that would do it. I guess that’s why they call it unstable.

On 6 Jan 2016, at 16:38, Andrew Hobden notifications@github.com wrote:

It's because rand is broken on nightly. :(


Reply to this email directly or view it on GitHub.

@Hoverbear Hoverbear self-assigned this Jan 8, 2016
@Hoverbear
Copy link
Owner

@homu r+

@homu
Copy link
Collaborator

homu commented Jan 11, 2016

📌 Commit 88f138b has been approved by Hoverbear

homu added a commit that referenced this pull request Jan 11, 2016
remove $HOME hack and set multirust folder the 'correct' way

Multirust does, in fact, have a way to set its home dir, as [specified here](https://github.com/brson/multirust/blob/f3974f2b966476ad656afba311b50a9c23fe6d2e/src/multirust#L284)
@homu
Copy link
Collaborator

homu commented Jan 11, 2016

⌛ Testing commit 88f138b with merge 30fa4ee...

@homu
Copy link
Collaborator

homu commented Jan 11, 2016

☀️ Test successful - status

@homu homu merged commit 88f138b into Hoverbear:master Jan 11, 2016
@Hoverbear
Copy link
Owner

@thisishugo Awesome, thanks so much!

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants