Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Move annotations from RosettaCore -> RosettaAnnotations #98

Merged
merged 2 commits into from
Sep 19, 2023

Conversation

emilymalison
Copy link

This PR moves a couple of annotations from the RosettaCore module to the RosettaAnnotations module.

@stevie400

@stevie400
Copy link
Contributor

tagging more people @jhaber @suruuK @Xcelled

@jhaber
Copy link
Member

jhaber commented Sep 18, 2023

Sounds good to me. We could theoretically change the method signature from Class<? extends JsonDeserializer> using(); -> Class<?> using(); which eliminates the jackson-databind dependency, but at the expense of being more error-prone

@stevie400 stevie400 merged commit 01e3d91 into master Sep 19, 2023
@stevie400 stevie400 deleted the emilymalison/move-core-annotations branch September 19, 2023 13:57
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants