Merge pull request #894 from HubSpot/task_kill_checkbox_label

Task kill checkbox label
HubSpot · Feb 23, 2016 · 96469bb · 96469bb
2 parents 2fd887f + 118487a
commit 96469bb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/SingularityUI/app/templates/vex/requestBounce.hbs b/SingularityUI/app/templates/vex/requestBounce.hbs
@@ -4,8 +4,10 @@
 	Bouncing a request will cause replacement tasks to be scheduled
 	(and under normal conditions) executed immediately.
 </p>
+<label for="no-incremental-bounce" id="no-incremental-bounce-label">
+    <input type="radio" name="incremental" id="no-incremental-bounce" value="false" checked> Kill old tasks once ALL new tasks are healthy<br>
+</label>
 <label for="incremental-bounce" id="incremental-bounce-label">
-    <input type="radio" name="incremental" value="false" checked> Kill old tasks once ALL new tasks are healthy<br>
     <input type="radio" name="incremental" id="incremental-bounce" value="true"> Kill old tasks as new tasks become healthy
 </label>
 <label for="skip-healthchecks" id="skip-healthchecks-label">

diff --git a/SingularityUI/app/views/taskOverviewSubview.coffee b/SingularityUI/app/views/taskOverviewSubview.coffee
@@ -72,7 +72,10 @@ class taskOverviewSubview extends View
                             vex.dialog.buttons.NO
                         ]
                         input: """
-                            <input name="wait-for-replacement-task" id="wait-for-replacement-task" type="checkbox" #{checked} /> Wait for replacement task to start before killing this task
+                            <label name="wait-for-replacement-task-label" id="wait-for-replacement-task-label" for="wait-for-replacement-task">
+                                <input name="wait-for-replacement-task" id="wait-for-replacement-task" type="checkbox" #{checked} /> 
+                                Wait for replacement task to start before killing task
+                            </label>
                             <input name="message" type="text" placeholder="Message (optional)" />
                         """
                         message: templ id: @model.taskId