Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make requestUtilization map thread safe. #1850

Merged
merged 2 commits into from
Sep 26, 2018
Merged

Make requestUtilization map thread safe. #1850

merged 2 commits into from
Sep 26, 2018

Conversation

baconmania
Copy link
Contributor

The requestUtilizations map is iterated over when it gets loaded into a new HashMap here:

Singularity/SingularityService/src/main/java/com/hubspot/singularity/scheduler/SingularityLeaderCache.java

Line 460 in 2c77825

return new HashMap<>(requestUtilizations);

Because requestUtilizations wasn't previously threadsafe, we'd get occasional ConcurrentModificationExceptions here.

@ssalinas
Copy link
Member

🚢

@ssalinas ssalinas merged commit b8c5c42 into master Sep 26, 2018
@ssalinas ssalinas deleted the threadsafe-utilization-map branch September 26, 2018 13:28
@ssalinas ssalinas added this to the 0.21.0 milestone Sep 26, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.21.0
Development

Successfully merging this pull request may close these issues.
2 participants
@baconmania @ssalinas