Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

tweak cooldown thresholds and evaluation logic #1973

Merged
merged 2 commits into from
Jul 11, 2019
Merged

tweak cooldown thresholds and evaluation logic #1973

merged 2 commits into from
Jul 11, 2019

Conversation

ssalinas
Copy link
Member

  • There isn't a case where we want to evaluate cooldown on TASK_KILLED, skip if that's the status
  • Check for the most recent failure being outside the time window wasn't correct
  • Make cooldown clear a bit faster

@ssalinas ssalinas added the hs_qa label Jul 10, 2019
@sjeropkipruto
Copy link
Contributor

🚢

@ssalinas ssalinas merged commit 25115be into master Jul 11, 2019
@ssalinas ssalinas deleted the cooldown_tweaks_2 branch July 11, 2019 19:46
@ssalinas ssalinas added this to the 0.23.0 milestone Jul 18, 2019
@bydga bydga mentioned this pull request Sep 3, 2019
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ssalinas @sjeropkipruto