Run persisters in parallel #2270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosalind210
reviewed
Feb 23, 2022
SingularityService/src/main/java/com/hubspot/singularity/config/SingularityConfiguration.java
Show resolved
Hide resolved
|
🚢 |
|
Hey @rosalind210, it looks like you Commented instead of Approved this PR. No big deal here, but in the future, please ensure that your 👍 is reflected as an approval. Otherwise an audit is triggered by our compliance safeguards. |
|
@tcampbell the approval flow as far as I knew doesn't work for the open source projects. In the past they were only hooked up for a direct comment/ 🚢 . If that has changed we can change our workflow |
|
You're right, my bad. sorry about that. Please ignore. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows parallel execution of persister tasks within a type of persister (e.g. 5 parallel executions for the tsak history persister). The number of these is configurable as
historyPollerConcurrency