Factor out the Scheduler lock. #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgschmie
force-pushed
the
factor-out-lock
branch
2 times, most recently
from
f994ff4 to
368b216
Compare
Inject the scheduler lock object everywhere it is needed. Also break up the "parent injection" pattern which is not needed with DI for the poller classes that hang off SingularityLeaderOnlyPoller.
hgschmie
force-pushed
the
factor-out-lock
branch
from
368b216 to
efc198d
Compare
wsorenson
added a commit
that referenced
this pull request
Dec 10, 2014
Factor out the Scheduler lock.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inject the scheduler lock object everywhere it is needed. Also break
up the "parent injection" pattern which is not needed with DI for the
poller classes that hang off SingularityLeaderOnlyPoller.