Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add indicator for overdue tasks #382

Merged
merged 3 commits into from
Jan 7, 2015
Merged

add indicator for overdue tasks #382

merged 3 commits into from
Jan 7, 2015

Conversation

ssalinas
Copy link
Member

@ssalinas ssalinas commented Jan 7, 2015

This will add a small badge to tasks that are overdue:

  • On the request detail page
    screen shot 2015-01-07 at 11 16 22 am
  • On the task table page
    screen shot 2015-01-07 at 11 16 31 am

@tpetr

@tpetr
Copy link
Contributor

tpetr commented Jan 7, 2015

overall this looks good, i just have some small nitpicks with the visual style -- i think there's too much padding inside the badge. could we tweak this to make it more look like the DANGER label in bootstrap, and maybe remove the !?

screen shot 2015-01-07 at 11 21 49 am

@timmfin feel free to lay on your special UI sauce if you have a minute

@Eseb
Copy link
Contributor

Eseb commented Jan 7, 2015

I agree with @tpetr, I feel that using a button is the wrong choice for this sort of UI element. The badges are much more appropriate, and maybe put it right next to the timestamp rather than having it as its own column.

@ssalinas
Copy link
Member Author

ssalinas commented Jan 7, 2015

@tpetr @Eseb update the badge to look like this using label:
screen shot 2015-01-07 at 2 03 33 pm
except without the ! ...

@tpetr
Copy link
Contributor

tpetr commented Jan 7, 2015

megusta

tpetr added a commit that referenced this pull request Jan 7, 2015
add indicator for overdue tasks
@tpetr tpetr merged commit 1c86133 into master Jan 7, 2015
@ssalinas ssalinas deleted the overdue_tasks branch May 4, 2015 20:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants