Fix executor cleanup #386
Merged
Fix executor cleanup #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(tested successfully in |
| return singularityClient.getActiveTasks(JavaUtils.getHostAddress()); | ||
| } catch (SocketException e) { | ||
| throw Throwables.propagate(e); | ||
| final HttpRequest request = HttpRequest.newBuilder().setUrl(String.format(LOCAL_SLAVE_STATE_URL_FORMAT, JavaUtils.getHostAddress())).build(); |
There was a problem hiding this comment.
shouldn't this be part of our mesos client?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SingularityExecutorCleanup was using a deprecated endpoint to load tasks for a specific slave by its hostname. This PR changes the code to use the endpoint that looks up tasks by slave ID.
@wsorenson