Instantly overdue tasks #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 25, 2016 13:33
…ut it won't show the task at all where it should show the task as "PENDING"
…ing for within 1 minute of now, and overdue for >1 minute in the past
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scheduled tasks are shown as overdue the second after they were supposed to start up.
That is fine for most use cases, but when a task is bounced the replacement tasks are scheduled to start right away. Since it takes them a few seconds to start up, they're instantly marked as overdue.
With this pull request, tasks will show as scheduled if they're scheduled to start up more than a minute in the future. They'll show as pending if they're scheduled to start within a minute of now. And they'll only show as overdue if they are scheduled to start more than a minute ago.