feat: support Hugo v0.133+ by removing deprecated Hugo variable for Google Analytics #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
site.GoogleAnalytics is deprecated since Hugo v0.120.0 and would need to be changed to site.Config.Services.GoogleAnalytics.ID, which breaks compatibility with earlier Hugo versions. Thus, omit fetching this configuration variable since it should be set via Params anyways.
✅ Deploy Preview for academic-demo canceled.
|
gcushen
approved these changes
Sep 1, 2024
gcushen
changed the title
|
@rodrigoalcarazdelaosa Opened #3139 to fix this. |
2 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
site.GoogleAnalytics is deprecated since Hugo v0.120.0 and would need to be changed to site.Config.Services.GoogleAnalytics.ID, which breaks compatibility with earlier Hugo versions. Thus, omit fetching this configuration variable since it should be set via site.Params.marketing.analytics.google_analytics anyway.
On request of @gcushen via Discord discussion.