-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove MuJoCo dependency from SQIL notebook #800
Conversation
Pushed it here. Let's see what it does ... |
Seems like the SQIL notebook tests pass (even though other tests still fail due to issues addressed in other PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks fine to me, even though I'm missing context so I cannot speak for the high-level intent of whether replacing it with the Pendulum is the right choice. Only thing seems to be that you're no longer using seals? Is this intentional?
The context is in the linked issue #798. Basically we just wanted to get rid of the MuJoCo dependency in the test pipeline. So we just replaced the environment with anything basic that is not MuJoCO. |
Codecov Report
@@ Coverage Diff @@
## master #800 +/- ##
==========================================
- Coverage 96.38% 96.33% -0.05%
==========================================
Files 95 98 +3
Lines 8901 9177 +276
==========================================
+ Hits 8579 8841 +262
- Misses 322 336 +14
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Description
Fixes #798.
WIP: @ernestum can you make a HuggingFace dataset
ppo-Pendulum-v1
out of the same-name model? I think that will be enough to make this notebook work. I'm not sure how you generated datasets so deferring to you on this.