feat: include viem chains rpcs #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrettCleary
reviewed
Jul 11, 2024
| const viemChain = viemChainsMap[metadata_i.chainId]; | ||
|
|
||
| if (viemChain) { | ||
| metadata_i.rpc = [...viemChain.rpcUrls.default.http, ...metadata_i.rpc] |
There was a problem hiding this comment.
wondering if we should just supply the viem chain rpc's only if they exist since the ethereum-list ones are so flaky
There was a problem hiding this comment.
I don't the non viem rpcs are necessarily incorrect, so I don't see any reason to not include them
One thing we can do is filter out the rpcs that need API keys like https://mainnet.infura.io/v3/${INFURA_API_KEY}, which is present in a couple of chains
There was a problem hiding this comment.
sounds good. I'm okay with including both. as long as we know to start from the front of the array.
we have options to pass the infura or alchemy api get in the getChainMetadata params and it will replace those api keys and return a useable RPC url
BrettCleary
approved these changes
Jul 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.