wait before error quit #269
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasm-ttd
reviewed
Nov 2, 2023
| // allow log to be flushed before quit app. | ||
| try { | ||
| Thread.sleep(1000); | ||
| } catch (InterruptedException e) { |
There was a problem hiding this comment.
Is it worth catching all exceptions here?
thomasm-ttd
approved these changes
Nov 3, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait a bit before error quit during bootstrap. Allow error log to be flushed to logs.
((LoggerContext)org.slf4j.LoggerFactory.getILoggerFactory()).stop();actually does not work - it depends on OS buffer implementation.This is a known issue: https://jira.qos.ch/browse/LOGBACK-735
Without this fix we will see weird log truncation in GCP. The real exception will not be logged - not friendly for touble shooting.