Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Sort columns of timeseries() with mixed time domain #896

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Dec 16, 2024

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR ensures that timeseries() returns a meaningfully sorted dataframe even for data with mixed time domain.

@danielhuppmann danielhuppmann self-assigned this Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.0%. Comparing base (ddbb88e) to head (acd1a93).
Report is 40 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main    #896    +/-   ##
======================================
  Coverage   95.0%   95.0%            
======================================
  Files         64      65     +1     
  Lines       6134    6332   +198     
======================================
+ Hits        5828    6019   +191     
- Misses       306     313     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhuppmann danielhuppmann merged commit 1ef2e7b into IAMconsortium:main Dec 16, 2024
14 checks passed
@danielhuppmann danielhuppmann deleted the feature/timeseries-mixed-domain branch December 16, 2024 16:03
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant