Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add implementation for to_netcdf() #899

Merged

Conversation

danielhuppmann
Copy link
Member

@danielhuppmann danielhuppmann commented Dec 18, 2024

Please confirm that this PR has done the following:

  • Tests Added
  • Documentation Added
  • Name of contributors Added to AUTHORS.rst
  • Description in RELEASE_NOTES.md Added

Description of PR

This PR refactors #898 to use the internal pd.Series object for efficiency.

@danielhuppmann danielhuppmann self-assigned this Dec 18, 2024
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.0%. Comparing base (ddbb88e) to head (266ef92).
Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
pyam/netcdf.py 83.3% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##            main    #899    +/-   ##
======================================
  Coverage   95.0%   95.0%            
======================================
  Files         64      66     +2     
  Lines       6134    6387   +253     
======================================
+ Hits        5828    6074   +246     
- Misses       306     313     +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhuppmann danielhuppmann mentioned this pull request Dec 18, 2024
4 tasks
@danielhuppmann
Copy link
Member Author

Merging to make a new release before the end of the year and send announcements before the break

@danielhuppmann danielhuppmann merged commit 19706ca into IAMconsortium:main Dec 19, 2024
14 checks passed
@danielhuppmann danielhuppmann deleted the feature/write_netcdf branch December 19, 2024 08:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant