Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: rename hover step to align with other mouse steps #70

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

mario-s
Copy link
Contributor

@mario-s mario-s commented Sep 13, 2024

This PR will rename the Hover step, but still keeps it to be backwards compatible.

@mario-s mario-s requested a review from derdualist September 13, 2024 13:15
@mario-s mario-s self-assigned this Sep 13, 2024
@mario-s mario-s marked this pull request as draft September 13, 2024 13:18
@mario-s mario-s force-pushed the fix/naming_move_over branch from 9ad289c to 0fd22f3 Compare September 13, 2024 13:22
@mario-s mario-s marked this pull request as ready for review September 13, 2024 13:24
@@ -886,25 +886,25 @@ Support
|:-----:|:--------------:|:----------:|:--------------:|:----------:|
| ✔ | ✔ | ✔ | ? | ? |

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add the
## Move over \<by> = \<by_value>
doc, and just link it and explain that it does the same? On second thought I think we should not deprecate the hover over, because it is a common expression and it might make this step easier to find.

@mario-s mario-s force-pushed the fix/naming_move_over branch from 0dea6a1 to 6b239da Compare September 13, 2024 14:22
@mario-s mario-s merged commit ad34ce9 into dev Sep 13, 2024
6 checks passed
@mario-s mario-s deleted the fix/naming_move_over branch September 13, 2024 14:25
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants