Skip to content

Commit

Permalink
chore(config): make DefaultVersion V2_0_0_0
Browse files Browse the repository at this point in the history
Also put default SASLHandshake version back to V1

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
  • Loading branch information
dnwe committed Aug 7, 2023
1 parent bb864d7 commit 765bfa3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
3 changes: 1 addition & 2 deletions config.go
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,6 @@ type Config struct {
// Consumer is the namespace for configuration related to consuming messages,
// used by the Consumer.
Consumer struct {

// Group is the namespace for configuring consumer group.
Group struct {
Session struct {
Expand Down Expand Up @@ -514,7 +513,7 @@ func NewConfig() *Config {
c.Net.ReadTimeout = 30 * time.Second
c.Net.WriteTimeout = 30 * time.Second
c.Net.SASL.Handshake = true
c.Net.SASL.Version = SASLHandshakeV0
c.Net.SASL.Version = SASLHandshakeV1

c.Metadata.Retry.Max = 3
c.Metadata.Retry.Backoff = 250 * time.Millisecond
Expand Down
2 changes: 1 addition & 1 deletion utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ var (
}
MinVersion = V0_8_2_0
MaxVersion = V3_5_1_0
DefaultVersion = V1_0_0_0
DefaultVersion = V2_0_0_0

// reduced set of protocol versions to matrix test
fvtRangeVersions = []KafkaVersion{
Expand Down

0 comments on commit 765bfa3

Please # to comment.