Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(examples): sync exactly_once and consumergroup #2614

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Aug 21, 2023

  • ensure both examples handle sarama.ErrClosedConsumerGroup in the Consume for { ... } loop and ignore that error as it means the user has closed the ConsumerGroup directly via Close().
  • ensure exactly_once handles the Messages() channel being closed with an ok check.
  • copy assignment strategy optional flag from consumergroup into exactly_once sample
  • bump the go.mod of both to specify 1.40.1 by default (although we still replace to ../.. anyway)

- ensure both examples handle sarama.ErrClosedConsumerGroup in the
  Consume for { ... } loop and ignore that error as it means the user
  has closed the ConsumerGroup directly via Close().
- ensure exactly_once handles the Messages() channel being closed with
  an ok check.
- copy assignment strategy optional flag from consumergroup into
  exactly_once sample
- bump the go.mod of both to specify 1.40.1 by default (although we
  still replace to ../.. anyway)

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@dnwe dnwe added the fix label Aug 21, 2023
@dnwe dnwe merged commit d4dc7bc into main Aug 21, 2023
@dnwe dnwe deleted the dnwe/examples branch August 21, 2023 17:17
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant