Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

setup.cfg->pyproject.toml, setuptools_scm #50

Merged
merged 1 commit into from
Oct 15, 2024
Merged

setup.cfg->pyproject.toml, setuptools_scm #50

merged 1 commit into from
Oct 15, 2024

Conversation

dweindl
Copy link
Member

@dweindl dweindl commented Oct 8, 2024

  • Move most package configuration to pyproject.toml
  • Use setuptools_scm for automated generation of version numbers based on git tags
  • Remove unnecessary setup.py

@dweindl dweindl self-assigned this Oct 8, 2024
@dweindl dweindl requested a review from dilpath October 8, 2024 18:03
@dweindl dweindl force-pushed the setuptools_scm branch 2 times, most recently from 1ff309f to 7615a57 Compare October 9, 2024 10:53
* Move most package configuration to pyproject.toml
* Use setuptools_scm for automated generation of version numbers based on git tags
* replace version.py by dynamic version
Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, so if I commit to main with message "Release 0.2.3" and upload to PyPI, it will have fiddy==0.2.3?

@dweindl
Copy link
Member Author

dweindl commented Oct 15, 2024

Thanks, so if I commit to main with message "Release 0.2.3" and upload to PyPI, it will have fiddy==0.2.3?

Almost. It's independent of any commit message, it's just about git tags. If you create a new release on GitHub via https://github.com/ICB-DCM/fiddy/releases/new, set the tag to v0.2.3 it will be deployed to PyPI as fiddy==0.2.3.

If you create an sdist/wheel for any non-tagged version, it will set the version to something like 0.1.2.dev7+gb1d85d5, where the pre-dev part is based on the last tag in the history. This is only relevant for installations of development versions. Setting the package version is independent of any PyPI deployments - the latter will (currently) only be triggered if a release is published on GitHub, not from pushing a v0.2.3 tag alone.

You can run python -m setuptools_scm in your fiddy repo to see which version string a package would currently get.

@dweindl dweindl merged commit 75f6a44 into main Oct 15, 2024
5 checks passed
@dweindl dweindl deleted the setuptools_scm branch October 15, 2024 05:42
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants