Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove mappings from el9 to ubuntu #1599

Merged
merged 1 commit into from
Mar 27, 2025
Merged

Conversation

mrmundt
Copy link
Contributor

@mrmundt mrmundt commented Mar 20, 2025

Fixes #1456

Summary/Motivation:

The infrastructure is already nicely defined in get-extensions to yell loudly / stop if someone is on an unrecognized platform or a platform not seen in the distribution map. We discussed in #1456 that we should not make an arbitrary mapping and instead tell the user to use the --distro option. This removes those arbitrary mappings, so now anyone who tries to run get-extensions on something we have not released will be given an error plus a help message.

Changes proposed in this PR:

  • Remove distributions that we do not officially support yet

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Mar 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.85%. Comparing base (02cd0e8) to head (4266427).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1599      +/-   ##
==========================================
- Coverage   76.85%   76.85%   -0.01%     
==========================================
  Files         394      394              
  Lines       63241    63241              
  Branches    10359    10359              
==========================================
- Hits        48604    48601       -3     
- Misses      12188    12192       +4     
+ Partials     2449     2448       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ksbeattie ksbeattie added the Priority:Normal Normal Priority Issue or PR label Mar 21, 2025
@ksbeattie ksbeattie merged commit 6e72af3 into IDAES:main Mar 27, 2025
28 of 48 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Priority:Normal Normal Priority Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

idaes get-extensions: All unidentified Linux distributions default to Ubuntu?
3 participants