No admin #126
Closed
No admin #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@enolfc can you remove the second commit? This is not needed anymore. |
alvarolopez
commented
Sep 28, 2023
caso/extract/manager.py
Outdated
| project = self.keystone.projects.get(project_id) | ||
| except (EmptyCatalog, Forbidden): | ||
| # we may need scoping here, retrying | ||
| LOG.warning(f"Scoping the keystone client to the current project {project_id}") |
There was a problem hiding this comment.
This will make flake8 complain
caso/extract/manager.py
Outdated
| client = keystone_client.get_client(CONF, system_scope="all") | ||
| if project: | ||
| system_scope = None | ||
| client = keystone_client.get_client(CONF, |
There was a problem hiding this comment.
This will make black unhappy
caso/extract/openstack/base.py
Outdated
| @@ -92,7 +92,7 @@ def _get_keystone_session(self): | |||
|
|
|||
| def _get_keystone_client(self): | |||
| """Get a Keystone Client for the configured project in the object.""" | |||
| client = keystone_client.get_client(CONF, system_scope="all") | |||
| client = keystone_client.get_client(CONF, project=self.project, system_scope="all") | |||
There was a problem hiding this comment.
This will make flake8 cry
Avoid issues when running cASO with a low privileges account that cannot list all projects and scope the tokens to the projects that are to be accounted. This allows to run cASO and generate records for non-admin users.
|
Fixed linter issues. Coverage still fails |
alvarolopez
force-pushed
the
pydantic2
branch
2 times, most recently
from
731c2ed to
fc85fad
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(shamelessly taken from #123 as this could not be reopened)
Description
Avoid issues when running cASO with a low privileges account that cannot
list all projects and scope the tokens to the projects that are to be
accounted. This allows to run cASO and generate records for non-admin
users.
Fixes #124
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. Please also list any relevant details for
your test configuration
caso-extractusingv3oidcaccesstokenauthentication with an EGI Check-in access token in 2 projects at IFCA-LCG2. Configuration:Checklist: