Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Value set url support #4

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

amol-wani-elimu
Copy link
Collaborator

@amol-wani-elimu amol-wani-elimu commented Aug 5, 2020

Hi @kaicode and @rorydavidson , I have done changes for latest sping-web version and style formatting.

@amol-wani-elimu
Copy link
Collaborator Author

Hi @kaicode, can you please update IHTSDO:master, its behind few commits of original sythea:master.
Then I will resolve merge conflicts in our pull request.

@kaicode kaicode force-pushed the ValueSetUrlSupport branch from c4c7982 to b092424 Compare August 13, 2020 09:18
@kaicode
Copy link
Member

kaicode commented Aug 13, 2020

Hi @amol-wani-elimu, I've rebase the IHTSDO:ValueSetUrlSupport branch against synthea:master, that was what needed doing. IHTSDO:master has some different commits so best to just leave that alone for now.
The merge conflict was just an import statement. Build and tests run well so I pushed the change. That has updated the pull request. Once the Travis build completes I'll let Andy know it's ready.

@amol-wani-elimu
Copy link
Collaborator Author

Ohk got yoy @kaicode, thanks for resolving and rebase against synthea:master

@kaicode
Copy link
Member

kaicode commented Aug 13, 2020

No worries, thanks @amol-wani-elimu.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants