General Makefile update and support for building multi-arch images #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the test suite requires a minimal Git configuration. The seed-via-docker.sh script normally takes care of that by mapping the calling user's own $HOME/.gitconfig file inside the Docker container used to run the tests, but this assumes that the calling user does have a .gitconfig file -- an assumption that is seemingly wrong on the machines used to run the Github Actions workflows.
Rewrite some rules to avoid duplicated recipes. Remove useless docker- prefix from rule names. Add rules to build multi-arch images.
The deploy_m1 script is no longer necessary now that we can build multi-arch images from the standard Makefile.
Add a section in the developers' README on how to use buildx to build multi-arch images.
Add a workflow triggered on each release to build the multi-arch images and push them to Docker Hub.
Configure the build-and-test workflow to be automatically triggered only when a PR is opened, not everytime it is updated with new commits (to save runtime credits). Also add the possibility to manually trigger the workflows.
matentzn
reviewed
May 20, 2021
We won't use Travis CI anymore now that we have the GA workflows in place.
The VERSION variable in docker/odklite/Makefile is overriden by the top-level Makefile, bit it should still be kept in sync in the sub-level Makefile in case someone wants to build odklite only.
This was referenced May 21, 2021
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces both PR #422 and #423.
It provides:
buildx;It also fixes running the tests in situations where the user calling
make testsdoes not have a~/.gitconfigfile.[1] As part of this change,
make docker-buildbecomesmake buildandmake docker-testbecomesmake tests; the README has been updated accordingly to provide up-to-date instructions.[2] Automatically publishing the images requires the repository to be configured with two secrets for the username and password for the
obolibraryDocker account (DOCKER_USERNAMEandDOCKER_PASSWORD).