Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add new term request github issue template #898

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

matentzn
Copy link
Contributor

No description provided.

@matentzn matentzn added this to the 1.5 milestone Feb 24, 2024
@matentzn matentzn self-assigned this Feb 24, 2024
@matentzn matentzn marked this pull request as ready for review February 24, 2024 17:16
@hrshdhgd
Copy link
Contributor

jinja is not my strong suite. I'll defer to @cmungall ... sorry!

Copy link
Contributor

@hrshdhgd hrshdhgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the looks of it looks good to my naive eyes!

attributes:
label: Website URL
description: Provide a website URL that you'd like to be associated with this new term.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be nothing but should the ' have an escaping \ before it?

@matentzn
Copy link
Contributor Author

@hrshdhgd i was asking you mostly to check compatibility with ontobot!

@hrshdhgd
Copy link
Contributor

hrshdhgd commented Feb 24, 2024

Too early for that. Trish and I are still trying to hash out obsolete template for now. Once things are finalized there, we will tackle new term request. I had new term request template handling coded up in ontobot but that seems to not work correctly at the moment.

@matentzn matentzn modified the milestones: 1.5, 1.6 Feb 25, 2024
@matentzn
Copy link
Contributor Author

Ok, thank you @hrshdhgd

Moving this to next ODK release (1.6)

@matentzn matentzn marked this pull request as draft February 25, 2024 06:22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants