Collect per-command resource usage data. #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running under ODK_DEBUG=yes, instruct the shell to run every command through a small wrapper around the actual shell to capture resource usage (CPU time and memory consumption) for each command, in addition to capturing resource usage for the entire run. The resource usage data is written into `tmp/debug.log`.
|
@matentzn @anitacaron I’ve done only limited testing of this for now. I’ll do more when I’m back next week. |
|
This looks great! @anitacaron when you have an opportunity can you test this? |
|
I tested it, and it looks good. |
matentzn
approved these changes
Nov 28, 2023
There was a problem hiding this comment.
My main concern with this is that the ODK_DEBUG parameter gets extended to a potentially breaking feature (writing a, potentially large logfile), but I don't really think this is a realistic concern, as the logs in practice are not thaaaat big, and certainly not bigger than the associated ontologies times 20. I am happy with merging this.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running under ODK_DEBUG=yes, instruct
maketo run every command through a small wrapper around the actual shell to capture resource usage (CPU time and memory consumption) for each command, in addition to capturing resource usage for the entire run. The resource usage data is written intotmp/debug.log.