bug: superInterfaces on shadow type miss actual type arguments

[pvojtechovsky]

I am refactoring SpoonMetaModel by way it can be created without spoon sources - just using spoon runtime reflection. And I have found this problem. For example CtConditionalImpl is defined like this

class CtConditionalImpl<T> implements CtConditional<T>

but when I get shadow CtClass of CtConditionalImpl, then getSuperInterfaces() returns CtTypeReference without actuall type arguments. So it looks like this

class CtConditionalImpl<T> implements CtConditional

I need that actual type argument on interface references, in ClassTypingContext.

This information was not available until Class#getAnnotatedInterfaces() was introduced in Java8. Could you please use that new method to deliver actual type arguments of extended interfaces too?

I created a branch with a failing test https://github.com/pvojtechovsky/spoon/tree/fixSuperIfaceArgs

[monperrus]

I am refactoring SpoonMetaModel by way it can be created without spoon sources - just using spoon runtime reflection

Excellent!

Could you please use that new method to deliver actual type arguments of extended interfaces too?

I'm not sure to understand, what do you mean?

[pvojtechovsky]

what do you mean?

to make the failing tests in https://github.com/pvojtechovsky/spoon/tree/fixSuperIfaceArgs passing

CtTypeReference ifaceRef = factory.Type.get(CtConditionalImpl.class).getSuperInterfaces().get(0);
ifaceRef.getActualTypeArguments() should return <T> but actually returns empty collection

[monperrus]

Do you mean that the JavaReflectionBuilder should be changed?

Are you working on this fix?

[pvojtechovsky]

Do you mean that the JavaReflectionBuilder should be changed?

yes

Are you working on this fix?

no. I do not know this code yet and I silently hope that somebody else might do it ;-)

I am actually cleaning new Template matching / generating code.... so we can start review/merging process soon.

[monperrus]

@surli would you have look at this bug with a failing test case?

[surli]

I'll look at it on the next days

[monperrus]

cool!

[pvojtechovsky]

Thank you :-) 👍