Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

review: refactor Environment to add encoding #1498

Merged
merged 6 commits into from
Aug 18, 2017

Conversation

surli
Copy link
Collaborator

@surli surli commented Aug 8, 2017

Add encoding in Environment and use it in CompilationUnit#getOriginalSourceCode()
Fix #1497

@msteinbeck
Copy link
Contributor

How about using Charset instead of a String?

@INRIA INRIA deleted a comment from spoon-bot Aug 8, 2017
@surli
Copy link
Collaborator Author

surli commented Aug 8, 2017

How about using Charset instead of a String?

Done.

@INRIA INRIA deleted a comment from spoon-bot Aug 8, 2017
@INRIA INRIA deleted a comment from spoon-bot Aug 8, 2017
@spoon-bot
Copy link
Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.9.0-20170807.224502-32

New API: fr.inria.gforge.spoon:spoon-core:jar:5.9.0-SNAPSHOT

Detected changes: 2.

Change 1

Name Element
Old none
New method java.nio.charset.Charset spoon.compiler.Environment::getEncoding()
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

Change 2

Name Element
Old none
New method void spoon.compiler.Environment::setEncoding(java.nio.charset.Charset)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking,

@INRIA INRIA deleted a comment from spoon-bot Aug 8, 2017
@monperrus
Copy link
Collaborator

add test?

@spoon-bot
Copy link
Collaborator

Revapi Analysis results

Old API: fr.inria.gforge.spoon:spoon-core:jar:5.9.0-20170817.224439-43

New API: fr.inria.gforge.spoon:spoon-core:jar:5.9.0-SNAPSHOT

Detected changes: 2.

Change 1

Name Element
Old none
New method java.nio.charset.Charset spoon.compiler.Environment::getEncoding()
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking

Change 2

Name Element
Old none
New method void spoon.compiler.Environment::setEncoding(java.nio.charset.Charset)
Code java.method.addedToInterface
Description Method was added to an interface.
Breaking binary: non_breaking

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants