review fix: issue related with Processor and generic types #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surli
changed the title
monperrus
reviewed
Aug 17, 2017
| @@ -45,10 +45,11 @@ private boolean canBeProcessed(CtElement e) { | |||
| if (!factory.getEnvironment().isProcessingStopped() | |||
| && processor.getProcessedElementTypes() != null) { | |||
| for (Object o : processor.getProcessedElementTypes()) { | |||
There was a problem hiding this comment.
add a multi-processor test with two incompatible elements
monperrus
reviewed
Aug 17, 2017
| @@ -45,10 +45,11 @@ private boolean canBeProcessed(CtElement e) { | |||
| if (!factory.getEnvironment().isProcessingStopped() | |||
| && processor.getProcessedElementTypes() != null) { | |||
There was a problem hiding this comment.
bug is in getProcessedElementTypes()
surli
changed the title
surli
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR propose a first solution to fix #1503 by overriding the method in the subclass.
It changes the behaviour of
ProcessingVisitor#canBeProcessedto consider the intersection of types instead of the union. => I don't know if considering the union of types was a wanted behavior or a mistake: in the first case, we have to had a new test to explicit the contract and the condition to use it.