Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

review chore:Use Maven INRIA instead of Gforge to deploy snapshots #1900

Merged
merged 4 commits into from
Mar 13, 2018

Conversation

surli
Copy link
Collaborator

@surli surli commented Mar 9, 2018

Fix #1900

⚠️ This PR might breaks for some time the snapshot deployment: I should have fixed it in the CI but I did not tested it, as I need this changes in the pom.xml file. Nervertheless I already deployed manually a first snapshot in order to avoid complete service discontinuity.

@surli surli changed the title Use Maven INRIA instead of Gforge to deploy snapshots review Use Maven INRIA instead of Gforge to deploy snapshots Mar 9, 2018
@surli surli changed the title review Use Maven INRIA instead of Gforge to deploy snapshots review chore:Use Maven INRIA instead of Gforge to deploy snapshots Mar 9, 2018
@monperrus
Copy link
Collaborator

There are also urls to change in the scripts in /doc

@surli
Copy link
Collaborator Author

surli commented Mar 12, 2018

There are also urls to change in the scripts in /doc

I think I replaced all mentions now: checked with a grep in the folder. If you know other locations of the mention, tell me.

pom.xml Outdated
@@ -169,9 +169,9 @@
<url>http://spoon.gforge.inria.fr/repositories/releases</url>
</repository>
<repository>
<id>gforge.inria.fr-snapshot</id>
<id>maven.inria.fr-snapshot</id>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can remove the whole repository tag since we release on Central, and lonly keep the snapshotRepository?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we can indeed. I just kept the same pattern as before.

pom.xml Outdated
<name>inria-snapshots</name>
<url>scp://scm.gforge.inria.fr/home/groups/spoon/htdocs/repositories/snapshots</url>
<id>maven.inria.fr-snapshot</id>
<name>http://maven.inria.fr-snapshots</name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about avoiding http://, it may be confusing, looking like a URL and not a name.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll change it.

@monperrus monperrus merged commit e6b98e8 into INRIA:master Mar 13, 2018
@monperrus
Copy link
Collaborator

I guess we have to update the Jenkins job? (at least to give the crendentials?)

@surli surli deleted the deploy-snapshot-on-maven-inria branch March 14, 2018 08:41
@surli
Copy link
Collaborator Author

surli commented Mar 14, 2018

I guess we have to update the Jenkins job? (at least to give the crendentials?)

Yes, I'm on it.

@surli surli mentioned this pull request Jun 25, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants