review: Fix failing builds because of the usage of random in CompilationUnit comparison #1954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's actually one remaining failing test on the job with the shuffling of CUs. The funny part is that actually I got the same error on my computer with JDK 9 for a while but I thought my configuration was broken somewhere. Actually it seems to be related with the order of resolution of CUs: so we already have a bug because of that. |
|
So I guess it's a WIP? |
surli
changed the title
|
It is but I'd be glad to get some help on this one ;) |
surli
changed the title
|
Apparently the error does not appear using JDK8 so I fixed it by changing TravisCI script to use JDK8. |
|
ping @monperrus it's ready now |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to fix the failing build created after the merge of #1938
Apparently we got lucky with the random when it was first executed: the usage of some random number could lead to the trigger of the following exception
IllegalArgumentException:Comparison method violates its general contract!This happens during the sort algorithm because as we use a random answer for sorting, the result is not transitive.
To avoid this problem I decided to completely remove the concept of seed and to just sort or shuffle the CU list, based on a switch value in the environment.
Before merging the PR I need to uncoment the lines of the shell script to make it only available on master commits: here I uncommented them only to check if travis is fixed.