Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

review fix: actualTypeArguments of array type reference #1997

Merged
merged 2 commits into from
May 21, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

I guess I have found a bug in actual type arguments of array type reference.
The problem is that array type reference like List<?>[] has set wildcard <?> actual type arguments on 2 places

  1. on List type: List<?> - here it is OK
  2. in List array type: List[] - here it is wrong. Or WDYT is it bug or feature?

I added two failing test, which both actually fails on last test line.

@pvojtechovsky pvojtechovsky changed the title failing test: actualTypeArguments of array type reference review fix: actualTypeArguments of array type reference May 19, 2018
@monperrus monperrus merged commit 799e5cd into INRIA:master May 21, 2018
@monperrus
Copy link
Collaborator

thanks!

@pvojtechovsky pvojtechovsky deleted the fixActTypeArgsArrayTypeRef branch May 22, 2018 04:23
@surli surli mentioned this pull request Jun 25, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants