Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

review: fix: position of (String arg[]) #2015

Merged
merged 3 commits into from
Jun 9, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

Position of parameter arg is incorrect in this code

void method(String arg[])

@pvojtechovsky
Copy link
Collaborator Author

pvojtechovsky commented May 30, 2018

@tdurieux this is an interesting case ... String arg[] the CtParameter.getType.getPosition must return String arg[] ... including parameter name... What SourcePosition type we will use for that special case???
See test of this PR for details.

@tdurieux
Copy link
Collaborator

:/ Java...

I'm not sure, I would say DeclarationSourcePosition

and the failing test-case is strange:
PositionTest.testArrayArgParameter:767 expected:<String arg[[]]> but was:<String arg[]> I don't understand the diff

@surli surli mentioned this pull request Jun 7, 2018
@surli surli changed the title WIP: fix: position of (String arg[]) review: fix: position of (String arg[]) Jun 8, 2018
@monperrus monperrus merged commit db37d87 into INRIA:master Jun 9, 2018
@pvojtechovsky pvojtechovsky deleted the fixPosArrayType branch June 9, 2018 08:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants