Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

doc: fix javadoc in TypeFactory.java #2688

Merged
merged 4 commits into from
Oct 20, 2018
Merged

doc: fix javadoc in TypeFactory.java #2688

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2743c06
refactor: remove redundant cast
zielint0 Oct 18, 2018
43717df
fix typos
zielint0 Oct 18, 2018
fd38fe8
fix one
zielint0 Oct 19, 2018
2e1859d
restore cast (it is fixed in other pr)
zielint0 Oct 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions src/main/java/spoon/reflect/factory/TypeFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ public <T> CtArrayTypeReference<T[]> createArrayReference(CtType<T> type) {
}

/**
* Creates a reference to a one-dimension array of given type.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"a one" is correct, see https://www.quora.com/Which-is-correct-a-one-or-an-one

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monperrus
That's right. Thank you for your careful review!

* Creates a reference to an one-dimension array of given type.
*/
public <T> CtArrayTypeReference<T[]> createArrayReference(CtTypeReference<T> reference) {
CtArrayTypeReference<T[]> array = factory.Core().createArrayTypeReference();
Expand All @@ -291,7 +291,7 @@ public <T> CtArrayTypeReference<T[]> createArrayReference(CtTypeReference<T> ref
}

/**
* Creates a reference to an n-dimension array of given type.
* Creates a reference to a n-dimension array of given type.
*/
public CtArrayTypeReference<?> createArrayReference(CtTypeReference<?> reference, int n) {
CtTypeReference<?> componentType;
Expand Down Expand Up @@ -540,7 +540,7 @@ private void addNestedType(List<CtType<?>> list, CtType<?> t) {

/**
* Gets a type from its runtime Java class. If the class isn't in the spoon path,
* the class will be build from the Java reflection and will be marked as
* the class will be built from the Java reflection and will be marked as
* shadow (see {@link spoon.reflect.declaration.CtShadowable}).
*
* @param <T>
Expand Down Expand Up @@ -678,7 +678,7 @@ public <T> void visitCtConstructor(CtConstructor<T> c) {
}
}
Visitor visitor = new Visitor();
((CtElement) formalTypeDeclarer).accept(visitor);
formalTypeDeclarer.accept(visitor);
return visitor.adapter;
}

Expand Down Expand Up @@ -715,5 +715,4 @@ public CtImport createImport(CtReference reference) {
CtImport ctImport = factory.Core().createImport();
return ctImport.setReference(reference.clone());
}

}