fix: MetamodelProperty#containerKindOf knows Collection now #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monperrus
reviewed
Oct 22, 2018
| @@ -600,7 +601,7 @@ private static ContainerKind containerKindOf(Class<?> valueClass) { | |||
| if (Map.class.isAssignableFrom(valueClass)) { | |||
| return ContainerKind.MAP; | |||
| } | |||
| if (Set.class.isAssignableFrom(valueClass)) { | |||
| if (Set.class.isAssignableFrom(valueClass) || Collection.class.isAssignableFrom(valueClass)) { | |||
There was a problem hiding this comment.
Set is a subtype of Collection so only the second part is necessary
Suggested change
| if (Set.class.isAssignableFrom(valueClass) || Collection.class.isAssignableFrom(valueClass)) { | |
| if (Collection.class.isAssignableFrom(valueClass)) { |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little change needed by #2702
There is no way how to test it. The "test" comes with #2702 after spoon model starts use
Collectionin some API methods.