Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: CtImportVisitor #2730

Merged
merged 2 commits into from
Nov 8, 2018
Merged

feat: CtImportVisitor #2730

merged 2 commits into from
Nov 8, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

@pvojtechovsky pvojtechovsky commented Oct 30, 2018 •
edited
Loading

Simplifies work with different kinds of imports -> CtImportVisitor

@pvojtechovsky pvojtechovsky changed the title feat: CtImportVisitor WIP feat: CtImportVisitor Oct 30, 2018
@pvojtechovsky pvojtechovsky force-pushed the feaImportVisitor branch 2 times, most recently from 126e871 to 4e9c861 Compare November 1, 2018 17:46
@spoon-bot
Copy link
Collaborator

API changes: 6 (Detected by Revapi)

Old API: fr.inria.gforge.spoon:spoon-core:jar:7.2.0-20181101.234717-66 / New API: fr.inria.gforge.spoon:spoon-core:jar:7.2.0-SNAPSHOT

Method was added to an interface.
Old none
New method CtImport#accept(CtImportVisitor)
Breaking binary: non_breaking
Method was added to an interface.
Old none
New method CoreFactory#createTypeMemberWildcardImportReference()
Breaking binary: non_breaking
Method was added to an interface.
Old none
New method Factory#createTypeMemberWildcardImportReference(CtTypeReference)
Breaking binary: non_breaking
Method was removed.
Old method CoreFactory#createWildcardStaticTypeMemberReference()
New none
Breaking binary: breaking,
Method was removed.
Old method Factory#createWildcardStaticTypeMemberReference(CtTypeReference)
New none
Breaking binary: breaking,
Method was added to an interface.
Old none
New method CtVisitor#visitCtTypeMemberWildcardImportReference(CtTypeMemberWildcardImportReference)
Breaking binary: non_breaking

@pvojtechovsky pvojtechovsky changed the title WIP feat: CtImportVisitor feat: CtImportVisitor Nov 6, 2018
@pvojtechovsky
Copy link
Collaborator Author

It is ready for review.

@monperrus
Copy link
Collaborator

LGTM.

@monperrus monperrus merged commit 42caaa7 into INRIA:master Nov 8, 2018
@pvojtechovsky pvojtechovsky deleted the feaImportVisitor branch November 8, 2018 19:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pvojtechovsky @spoon-bot @monperrus