-
-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add encoding detection callback #2788
Merged
Merged
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
28 changes: 28 additions & 0 deletions
28
src/main/java/spoon/compiler/builder/EncodingProvider.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/** | ||
* Copyright (C) 2006-2018 INRIA and contributors | ||
* Spoon - http://spoon.gforge.inria.fr/ | ||
* | ||
* This software is governed by the CeCILL-C License under French law and | ||
* abiding by the rules of distribution of free software. You can use, modify | ||
* and/or redistribute the software under the terms of the CeCILL-C license as | ||
* circulated by CEA, CNRS and INRIA at http://www.cecill.info. | ||
* | ||
* This program is distributed in the hope that it will be useful, but WITHOUT | ||
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
* FITNESS FOR A PARTICULAR PURPOSE. See the CeCILL-C License for more details. | ||
* | ||
* The fact that you are presently reading this means that you have had | ||
* knowledge of the CeCILL-C license and that you accept its terms. | ||
*/ | ||
package spoon.compiler.builder; | ||
|
||
import spoon.compiler.SpoonFile; | ||
import java.nio.charset.Charset; | ||
|
||
public interface EncodingProvider { | ||
|
||
/** | ||
* User-defined function, which is used to detect encoding for each file | ||
*/ | ||
Charset detectEncoding(SpoonFile file, byte[] fileBytes); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -19,6 +19,9 @@ | |
import org.apache.commons.lang3.StringUtils; | ||
import org.junit.Test; | ||
import spoon.Launcher; | ||
import spoon.SpoonException; | ||
import spoon.compiler.SpoonFile; | ||
import spoon.reflect.CtModel; | ||
import spoon.reflect.cu.CompilationUnit; | ||
import spoon.reflect.cu.SourcePosition; | ||
import spoon.reflect.cu.position.BodyHolderSourcePosition; | ||
|
@@ -42,12 +45,14 @@ | |
import java.util.List; | ||
|
||
import static org.junit.Assert.assertEquals; | ||
import static org.junit.Assert.assertNotEquals; | ||
import static org.junit.Assert.assertNotNull; | ||
import static org.junit.Assert.assertNull; | ||
import static org.junit.Assert.assertSame; | ||
import static org.junit.Assert.assertTrue; | ||
import static org.junit.Assert.fail; | ||
|
||
|
||
/** | ||
* Created by urli on 18/08/2017. | ||
*/ | ||
|
@@ -267,4 +272,40 @@ public void visitCtCompilationUnit(CtCompilationUnit compilationUnit) { | |
} | ||
}.scan(type.getFactory().getModel().getRootPackage()); | ||
} | ||
|
||
private Charset detectEncodingDummy(SpoonFile unused, byte[] fileBytes) { | ||
if (fileBytes.length == 76) { | ||
return Charset.forName("Cp1251"); | ||
} else if (fileBytes.length == 86) { | ||
return Charset.forName("UTF-8"); | ||
} | ||
throw new SpoonException("unexpected length"); | ||
} | ||
|
||
@Test | ||
public void testDifferentEncodings() throws Exception { | ||
//contract: both utf-8 and cp1251 files in the same project should be handled properly | ||
final Launcher launcher = new Launcher(); | ||
launcher.addInputResource("./src/test/resources/encodings/Cp1251.java"); | ||
launcher.addInputResource("./src/test/resources/encodings/Utf8.java"); | ||
launcher.getEnvironment().setEncodingProvider(this::detectEncodingDummy); | ||
CtModel model = launcher.buildModel(); | ||
|
||
CtType<?> utf8Type = model.getAllTypes() | ||
.stream() | ||
.filter(t -> "Utf8".equals(t.getSimpleName())) | ||
.findFirst() | ||
.get(); | ||
|
||
CtType<?> cp1251Type = model.getAllTypes() | ||
.stream() | ||
.filter(t -> "Cp1251".equals(t.getSimpleName())) | ||
.findFirst() | ||
.get(); | ||
|
||
assertEquals("\"Привет мир\"", utf8Type.getField("s1").getAssignment().toString()); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I love this expected value :-) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you don't read Cyrillic, it means "Hello World" :) |
||
assertEquals("\"Привет мир\"", cp1251Type.getField("s1").getAssignment().toString()); | ||
assertEquals(utf8Type.getField("s1"), cp1251Type.getField("s1")); | ||
assertNotEquals(utf8Type.getField("s2"), cp1251Type.getField("s2")); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
public class Cp1251 { | ||
String s1 = "������ ���"; | ||
String s2 = "���" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
public class Utf8 { | ||
String s1 = "Привет мир"; | ||
String s2 = "ГДЕ" | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contentStream must be closed. The best is:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooops, my bad, thanks.