Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feature: AllTypeMembersFunction mode=[All, SKIP_PRIVATE] #2803

Merged
merged 4 commits into from
Dec 1, 2018

Conversation

pvojtechovsky
Copy link
Collaborator

AllTypeMembersFunction can now return
A) all type members
B) only these type members which are visible in input type. It means inherited private type members are not returned

@pvojtechovsky pvojtechovsky changed the title WiP: feature: AllTypeMembersFunction mode=[All, INERNALLY_ACCESSIBLE] feature: AllTypeMembersFunction mode=[All, INERNALLY_ACCESSIBLE] Nov 30, 2018
@monperrus
Copy link
Collaborator

LGTM.

I'm not sure about the name INERNALLY_ACCESSIBLE (typo?)

According to the doc Returns only type members, which are accessible from the input type. It means that inherited private type members are skipped,

what about SKIP_PRIVATE_TYPE?

@pvojtechovsky
Copy link
Collaborator Author

yes, there is type. I will fix it

@pvojtechovsky
Copy link
Collaborator Author

SKIP_PRIVATE_TYPE

it is not about types. but about type members.

I renamed to SKIP_PRIVATE.

WDYT?

@pvojtechovsky pvojtechovsky changed the title feature: AllTypeMembersFunction mode=[All, INERNALLY_ACCESSIBLE] feature: AllTypeMembersFunction mode=[All, SKIP_PRIVATE] Dec 1, 2018
@monperrus monperrus merged commit 7ade841 into INRIA:master Dec 1, 2018
@pvojtechovsky pvojtechovsky deleted the feaAllTypeMembersMode branch December 1, 2018 19:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants