Print the full qualified name of the variable type when the parent of the type has generics #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1891,7 +1891,8 @@ public void visitCtCircularTypeReference(CtCircularTypeReference reference) { | |||
|
|
|||
| private <T> boolean hasDeclaringTypeWithGenerics(CtTypeReference<T> reference) { | |||
| // If current reference use generic types, we don't need this hack. | |||
| if (reference.getActualTypeArguments().size() != 0) { | |||
| if (reference.getActualTypeArguments().size() != 0 | |||
| && reference.getDeclaringType().getActualTypeArguments().size() == 0) { | |||
There was a problem hiding this comment.
Can you move this check below this check?
There was a problem hiding this comment.
The complete if or just my additional condition?
There was a problem hiding this comment.
Your additional condition. Potentially, reference.getDeclaringType() can be null.
There was a problem hiding this comment.
No, I cannot. but I can move the complete if
There was a problem hiding this comment.
Move the complete if.
tdurieux
force-pushed
the
fix-type-with-generic
branch
from
82bc11b to
404cee2
Compare
GerardPaligot
added a commit
that referenced
this pull request
Oct 26, 2015
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.