wip: fix: keep implicit modifiers in reflective proxies #4075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I-Al-Istannen
changed the title
I-Al-Istannen
force-pushed
the
fix/implicit-modifiers-reflective-proxy
branch
from
6316565 to
b99bf57
Compare
|
Let's hold a minute of silence for this PR that was open for two months but is now completely contained in #4205. |
|
done, and to stay on the positive side, let's celebrate that #4205 is merged.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked
This PR is blocked by #4205 as it does the same thing.
Problem
Spoon adds implicit
public abstractmodifiers to methods (as they are present in the MethodBinding) but explicitly ignores them in the reflective model. This is IMHO quite unexpected and should be fixed.Solution in this PR
This PR just removes the checks added by #1914. I couldn't really find any justification for ignoring them but maybe the MethodBinding was different back then. They were introduced in commit 2fc84bb if you want to have a look.
We can not mark the modifiers as implicit as far as I can tell, as reflection doesn't really tell us whether it was present in the source code or added implicitly.