WIP: feat(CtArrayTypeReference): store printing information of array declaration in AST #4344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds another meta-model information to
CtArrayTypeReference
-ARRAY_DECLARATION_KIND
. Java has two ways to place[]
for array declaration.int[] array
int array[]
Although the convention discourages the latter form of declaration, it is still allowed.
Currently, Spoon is unable to print
[]
after the variable name. See #4315 . Storing this information in the meta-model is a nice solution to it, but I also agree with @slarse here. Printing information has always been kept out of AST and that's why we have implemented a sniper printer in the first place.Another solution is to add a function called
printBracketsIfRequired
here inDJPP::visitCtField
. See "how it prints identifier".