Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

test: migrate CtBodyHolderTest to JUnit 5 #4493

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

MartinWitt
Copy link
Collaborator

#3919

Change Log

The following bad smells are refactored:

JUnit4-@test

The JUnit 4 @Test annotation should be replaced with JUnit 5 @Test annotation.

JUnit4Assertion

The JUnit4 assertion should be replaced with JUnit5 Assertions.

The following has changed in the code:

JUnit4-@test

  • Replaced junit 4 test annotation with junit 5 test annotation in testConstructor
  • Replaced junit 4 test annotation with junit 5 test annotation in testMethod
  • Replaced junit 4 test annotation with junit 5 test annotation in testTryCatch
  • Replaced junit 4 test annotation with junit 5 test annotation in testForWithStatement
  • Replaced junit 4 test annotation with junit 5 test annotation in testForWithBlock
  • Replaced junit 4 test annotation with junit 5 test annotation in testWhileWithBlock

JUnit4Assertion

  • Transformed junit4 assert to junit 5 assertion in testConstructor
  • Transformed junit4 assert to junit 5 assertion in testMethod
  • Transformed junit4 assert to junit 5 assertion in testTryCatch
  • Transformed junit4 assert to junit 5 assertion in testForWithStatement
  • Transformed junit4 assert to junit 5 assertion in testForWithBlock
  • Transformed junit4 assert to junit 5 assertion in testWhileWithBlock
  • Transformed junit4 assert to junit 5 assertion in checkCtBody

 The following has changed in the code:
Replaced junit 4 test annotation with junit 5 test annotation in testConstructor
Replaced junit 4 test annotation with junit 5 test annotation in testMethod
Replaced junit 4 test annotation with junit 5 test annotation in testTryCatch
Replaced junit 4 test annotation with junit 5 test annotation in testForWithStatement
Replaced junit 4 test annotation with junit 5 test annotation in testForWithBlock
Replaced junit 4 test annotation with junit 5 test annotation in testWhileWithBlock
Transformed junit4 assert to junit 5 assertion in testConstructor
Transformed junit4 assert to junit 5 assertion in testMethod
Transformed junit4 assert to junit 5 assertion in testTryCatch
Transformed junit4 assert to junit 5 assertion in testForWithStatement
Transformed junit4 assert to junit 5 assertion in testForWithBlock
Transformed junit4 assert to junit 5 assertion in testWhileWithBlock
Transformed junit4 assert to junit 5 assertion in checkCtBody
Copy link
Collaborator

@slarse slarse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slarse slarse merged commit 924fc6a into INRIA:master Jan 14, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants